Fix a bug in Lutron RadioRA2 Scene support#19819
Merged
kellerza merged 1 commit intohome-assistant:devfrom Jan 6, 2019
Merged
Conversation
The main lutron component was not properly passing the keypad name to the scene component, resulting in a stack trace like so:
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 128, in _async_setup_platform
SLOW_SETUP_MAX_WAIT, loop=hass.loop)
File "/usr/local/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
return fut.result()
File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/local/lib/python3.6/site-packages/homeassistant/components/scene/lutron.py", line 22, in setup_platform
(area_name, keypad_name, device, led) = scene_data
ValueError: not enough values to unpack (expected 4, got 3)
homeassistant
added
cla-signed
integration: lutron
small-pr
ghost
added
the
balloob
pushed a commit
that referenced
this pull request
Jan 9, 2019
Merged
rymsha
pushed a commit
to rymsha/home-assistant
that referenced
this pull request
Jan 12, 2019
rymsha
pushed a commit
to rymsha/home-assistant
that referenced
this pull request
Jan 12, 2019
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Feb 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The main lutron component was not properly passing the keypad name to the scene component, resulting in a stack trace like so:
Checklist:
tox. Your PR cannot be merged unless tests pass